Skip to content

Commit

Permalink
fold debugfs_create() into caller
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Jan 25, 2015
1 parent 02538a7 commit 3473cde
Showing 1 changed file with 3 additions and 14 deletions.
17 changes: 3 additions & 14 deletions fs/debugfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,6 @@ static int debugfs_mknod(struct dentry *dentry,
return 0;
}

static int debugfs_create(struct dentry *dentry, umode_t mode,
void *data, const struct file_operations *fops)
{
struct inode *dir = dentry->d_parent->d_inode;
int res;

mode = (mode & S_IALLUGO) | S_IFREG;
res = debugfs_mknod(dentry, mode, data, fops);
if (!res)
fsnotify_create(dir, dentry);
return res;
}

static inline int debugfs_positive(struct dentry *dentry)
{
return dentry->d_inode && !d_unhashed(dentry);
Expand Down Expand Up @@ -362,7 +349,9 @@ struct dentry *debugfs_create_file(const char *name, umode_t mode,
if (IS_ERR(dentry))
return NULL;

error = debugfs_create(dentry, mode, data, fops);
error = debugfs_mknod(dentry, mode, data, fops);
if (!error)
fsnotify_create(dentry->d_parent->d_inode, dentry);
return end_creating(dentry, error);
}
EXPORT_SYMBOL_GPL(debugfs_create_file);
Expand Down

0 comments on commit 3473cde

Please sign in to comment.