Skip to content

Commit

Permalink
kgdboc: Change printk to the right fashion
Browse files Browse the repository at this point in the history
pr_* is preferred according to scripts/checkpatch.pl.

Cc: jason.wessel@windriver.com
Cc: gregkh@linuxfoundation.org
Cc: jslaby@suse.com
Signed-off-by: He Zhe <zhe.he@windriver.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
He Zhe authored and Greg Kroah-Hartman committed Sep 18, 2018
1 parent 1bd54d8 commit 39724d5
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions drivers/tty/serial/kgdboc.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
*
* 2007-2008 (c) Jason Wessel - Wind River Systems, Inc.
*/

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <linux/kernel.h>
#include <linux/ctype.h>
#include <linux/kgdb.h>
Expand Down Expand Up @@ -131,12 +134,12 @@ static void kgdboc_unregister_kbd(void)
static int kgdboc_option_setup(char *opt)
{
if (!opt) {
pr_err("kgdboc: config string not provided\n");
pr_err("config string not provided\n");
return -EINVAL;
}

if (strlen(opt) >= MAX_CONFIG_LEN) {
printk(KERN_ERR "kgdboc: config string too long\n");
pr_err("config string too long\n");
return -ENOSPC;
}
strcpy(config, opt);
Expand Down Expand Up @@ -253,7 +256,7 @@ static int param_set_kgdboc_var(const char *kmessage,
int len = strlen(kmessage);

if (len >= MAX_CONFIG_LEN) {
printk(KERN_ERR "kgdboc: config string too long\n");
pr_err("config string too long\n");
return -ENOSPC;
}

Expand All @@ -264,8 +267,7 @@ static int param_set_kgdboc_var(const char *kmessage,
}

if (kgdb_connected) {
printk(KERN_ERR
"kgdboc: Cannot reconfigure while KGDB is connected.\n");
pr_err("Cannot reconfigure while KGDB is connected.\n");

return -EBUSY;
}
Expand Down

0 comments on commit 39724d5

Please sign in to comment.