Skip to content

Commit

Permalink
drbd: drbd_adm_prepare(): Only set adm_ctx.connection when a connecti…
Browse files Browse the repository at this point in the history
…on is requested

Also change drbd_adm_connect() to expect a resource after it requested one.

Signed-off-by: Andreas Gruenbacher <agruen@linbit.com>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
  • Loading branch information
Andreas Gruenbacher authored and Philipp Reisner committed Feb 17, 2014
1 parent b6f85ef commit 3ab706f
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/block/drbd/drbd_nl.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,6 @@ static int drbd_adm_prepare(struct sk_buff *skb, struct genl_info *info,
adm_ctx.device = minor_to_device(d_in->minor);
if (adm_ctx.resource_name) {
adm_ctx.resource = drbd_find_resource(adm_ctx.resource_name);
if (adm_ctx.resource) {
adm_ctx.connection = first_connection(adm_ctx.resource);
kref_get(&adm_ctx.connection->kref);
}
}

if (!adm_ctx.device && (flags & DRBD_ADM_NEED_MINOR)) {
Expand All @@ -234,7 +230,7 @@ static int drbd_adm_prepare(struct sk_buff *skb, struct genl_info *info,
}

if (flags & DRBD_ADM_NEED_CONNECTION) {
if (adm_ctx.connection && !(flags & DRBD_ADM_NEED_RESOURCE)) {
if (adm_ctx.resource) {
drbd_msg_put_info("no resource name expected");
return ERR_INVALID_REQUEST;
}
Expand Down Expand Up @@ -2211,7 +2207,7 @@ int drbd_adm_connect(struct sk_buff *skb, struct genl_info *info)
}
}

connection = adm_ctx.connection;
connection = first_connection(adm_ctx.resource);
conn_reconfig_start(connection);

if (connection->cstate > C_STANDALONE) {
Expand Down

0 comments on commit 3ab706f

Please sign in to comment.