Skip to content

Commit

Permalink
hwmon: pmbus: Drop unnecessary clear fault page
Browse files Browse the repository at this point in the history
The pmbus_check_byte_register function already calls clear
fault page, so there's no need to do it again in
pmbus_identify_common.

TEST: Verified using an I2C bus analyser to confirm that only
      one clear fault page is being send instead of two in a row.

Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
Link: https://lore.kernel.org/r/20230817092527.808631-2-Naresh.Solanki@9elements.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Patrick Rudolph authored and Guenter Roeck committed Aug 21, 2023
1 parent 14cf45f commit 3fd2188
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/hwmon/pmbus/pmbus_core.c
Original file line number Diff line number Diff line change
@@ -2541,7 +2541,6 @@ static int pmbus_identify_common(struct i2c_client *client,
}
}

pmbus_clear_fault_page(client, page);
return 0;
}

0 comments on commit 3fd2188

Please sign in to comment.