Skip to content

Commit

Permalink
Revert "drm/color: un-inline drm_color_lut_extract()"
Browse files Browse the repository at this point in the history
This reverts commit 2eebe4f, because I
screwed up and applied it to the wrong branch.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
  • Loading branch information
Jani Nikula committed Jan 27, 2017
1 parent 05c41f9 commit 40f62bb
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 26 deletions.
24 changes: 0 additions & 24 deletions drivers/gpu/drm/drm_color_mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,30 +87,6 @@
* "GAMMA_LUT" property above.
*/

/**
* drm_color_lut_extract - clamp&round LUT entries
* @user_input: input value
* @bit_precision: number of bits the hw LUT supports
*
* Extract a degamma/gamma LUT value provided by user (in the form of
* &drm_color_lut entries) and round it to the precision supported by the
* hardware.
*/
uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision)
{
uint32_t val = user_input;
uint32_t max = 0xffff >> (16 - bit_precision);

/* Round only if we're not using full precision. */
if (bit_precision < 16) {
val += 1UL << (16 - bit_precision - 1);
val >>= 16 - bit_precision;
}

return clamp_val(val, 0, max);
}
EXPORT_SYMBOL(drm_color_lut_extract);

/**
* drm_crtc_enable_color_mgmt - enable color management properties
* @crtc: DRM CRTC
Expand Down
27 changes: 25 additions & 2 deletions include/drm/drm_color_mgmt.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

#include <linux/ctype.h>

uint32_t drm_color_lut_extract(uint32_t user_input, uint32_t bit_precision);

void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,
uint degamma_lut_size,
bool has_ctm,
Expand All @@ -35,4 +33,29 @@ void drm_crtc_enable_color_mgmt(struct drm_crtc *crtc,
int drm_mode_crtc_set_gamma_size(struct drm_crtc *crtc,
int gamma_size);

/**
* drm_color_lut_extract - clamp&round LUT entries
* @user_input: input value
* @bit_precision: number of bits the hw LUT supports
*
* Extract a degamma/gamma LUT value provided by user (in the form of
* &drm_color_lut entries) and round it to the precision supported by the
* hardware.
*/
static inline uint32_t drm_color_lut_extract(uint32_t user_input,
uint32_t bit_precision)
{
uint32_t val = user_input;
uint32_t max = 0xffff >> (16 - bit_precision);

/* Round only if we're not using full precision. */
if (bit_precision < 16) {
val += 1UL << (16 - bit_precision - 1);
val >>= 16 - bit_precision;
}

return clamp_val(val, 0, max);
}


#endif

0 comments on commit 40f62bb

Please sign in to comment.