Skip to content

Commit

Permalink
crypto: scatterwalk - Set the chain pointer indication bit
Browse files Browse the repository at this point in the history
The scatterwalk_crypto_chain function invokes the scatterwalk_sg_chain
function to chain two scatterlists, but the chain pointer indication
bit is not set.  When the resulting scatterlist is used, for example,
by sg_nents to count the number of scatterlist entries, a segfault occurs
because sg_nents does not follow the chain pointer to the chained scatterlist.

Update scatterwalk_sg_chain to set the chain pointer indication bit as is
done by the sg_chain function.

Cc: stable@vger.kernel.org
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Tom Lendacky authored and Herbert Xu committed Nov 28, 2013
1 parent fc019c7 commit 41da8b5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/crypto/scatterwalk.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ static inline void scatterwalk_sg_chain(struct scatterlist *sg1, int num,
{
sg_set_page(&sg1[num - 1], (void *)sg2, 0, 0);
sg1[num - 1].page_link &= ~0x02;
sg1[num - 1].page_link |= 0x01;
}

static inline struct scatterlist *scatterwalk_sg_next(struct scatterlist *sg)
Expand Down

0 comments on commit 41da8b5

Please sign in to comment.