Skip to content

Commit

Permalink
net: mdio: mux-meson-g12a: Convert to platform remove callback return…
Browse files Browse the repository at this point in the history
…ing void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Uwe Kleine-König authored and David S. Miller committed Sep 20, 2023
1 parent 0ec8935 commit 458eb39
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/mdio/mdio-mux-meson-g12a.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,21 +336,19 @@ static int g12a_mdio_mux_probe(struct platform_device *pdev)
return ret;
}

static int g12a_mdio_mux_remove(struct platform_device *pdev)
static void g12a_mdio_mux_remove(struct platform_device *pdev)
{
struct g12a_mdio_mux *priv = platform_get_drvdata(pdev);

mdio_mux_uninit(priv->mux_handle);

if (__clk_is_enabled(priv->pll))
clk_disable_unprepare(priv->pll);

return 0;
}

static struct platform_driver g12a_mdio_mux_driver = {
.probe = g12a_mdio_mux_probe,
.remove = g12a_mdio_mux_remove,
.remove_new = g12a_mdio_mux_remove,
.driver = {
.name = "g12a-mdio_mux",
.of_match_table = g12a_mdio_mux_match,
Expand Down

0 comments on commit 458eb39

Please sign in to comment.