From 465cf6767198817870c8da5659d4d309847ea954 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 10 Mar 2025 13:52:05 +0300 Subject: [PATCH] pinctrl: amd: isp411: Fix IS_ERR() vs NULL check in probe() The platform_get_resource() returns NULL on error. It doesn't return error pointers. Fix the error checking to match. Fixes: e97435ab09f3 ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl") Signed-off-by: Dan Carpenter Reviewed-by: Pratap Nirujogi Link: https://lore.kernel.org/617f4c77-7837-4e24-9f4d-620ecfedf924@stanley.mountain Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-amdisp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amdisp.c b/drivers/pinctrl/pinctrl-amdisp.c index ce21ed84b929..9256ed67bb20 100644 --- a/drivers/pinctrl/pinctrl-amdisp.c +++ b/drivers/pinctrl/pinctrl-amdisp.c @@ -183,8 +183,8 @@ static int amdisp_pinctrl_probe(struct platform_device *pdev) pdev->dev.init_name = DRV_NAME; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (IS_ERR(res)) - return PTR_ERR(res); + if (!res) + return -EINVAL; pctrl->gpiobase = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(pctrl->gpiobase))