From 48b77cdca50a180fd1f22f4ae3b3d1e4ec7d2e5c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Beh=C3=BAn?= Date: Fri, 18 Sep 2020 00:33:34 +0200 Subject: [PATCH] leds: ns2: remove unneeded variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No need to use variable found, we can determine whether the mode was found by comparing iterator variable to its limit. Signed-off-by: Marek BehĂșn Cc: Simon Guinot Cc: Simon Guinot Cc: Vincent Donnefort Cc: Thomas Petazzoni Cc: Linus Walleij Signed-off-by: Pavel Machek --- drivers/leds/leds-ns2.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c index 9d9c9ff4dce61..e94bb8535f0a7 100644 --- a/drivers/leds/leds-ns2.c +++ b/drivers/leds/leds-ns2.c @@ -71,16 +71,13 @@ static int ns2_led_get_mode(struct ns2_led *led, enum ns2_led_modes *mode) static void ns2_led_set_mode(struct ns2_led *led, enum ns2_led_modes mode) { int i; - bool found = false; unsigned long flags; for (i = 0; i < led->num_modes; i++) - if (mode == led->modval[i].mode) { - found = true; + if (mode == led->modval[i].mode) break; - } - if (!found) + if (i == led->num_modes) return; write_lock_irqsave(&led->rw_lock, flags);