Skip to content

Commit

Permalink
ocfs2: Remove ocfs2_sync_inode()
Browse files Browse the repository at this point in the history
ocfs2_sync_inode() is used only from ocfs2_sync_file(). But all data has
already been written before calling ocfs2_sync_file() and ocfs2 doesn't use
inode's private_list for tracking metadata buffers thus sync_mapping_buffers()
is superfluous as well.

Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
  • Loading branch information
Jan Kara authored and Joel Becker committed Sep 10, 2010
1 parent 83fd9c7 commit 4c38881
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions fs/ocfs2/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@

#include "buffer_head_io.h"

static int ocfs2_sync_inode(struct inode *inode)
{
filemap_fdatawrite(inode->i_mapping);
return sync_mapping_buffers(inode->i_mapping);
}

static int ocfs2_init_file_private(struct inode *inode, struct file *file)
{
struct ocfs2_file_private *fp;
Expand Down Expand Up @@ -187,10 +181,6 @@ static int ocfs2_sync_file(struct file *file, int datasync)
mlog_entry("(0x%p, 0x%p, %d, '%.*s')\n", file, dentry, datasync,
dentry->d_name.len, dentry->d_name.name);

err = ocfs2_sync_inode(dentry->d_inode);
if (err)
goto bail;

if (datasync && !(inode->i_state & I_DIRTY_DATASYNC)) {
/*
* We still have to flush drive's caches to get data to the
Expand Down

0 comments on commit 4c38881

Please sign in to comment.