Skip to content

Commit

Permalink
clk: visconti: Remove pointless NULL check in visconti_pll_add_lookup()
Browse files Browse the repository at this point in the history
Clang warns:

drivers/clk/visconti/pll.c:292:20: warning: address of array 'ctx->clk_data.hws' will always evaluate to 'true' [-Wpointer-bool-conversion]
        if (ctx->clk_data.hws && id)
            ~~~~~~~~~~~~~~^~~ ~~
1 warning generated.

This array cannot be NULL if ctx is not NULL, which is allocated in
visconti_init_pll(), so just remove the check, which matches other clk
drivers.

Fixes: b4cbe60 ("clk: visconti: Add support common clock driver and reset driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/1564
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220107183303.2337676-1-nathan@kernel.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Nathan Chancellor authored and Stephen Boyd committed Jan 8, 2022
1 parent 70faf94 commit 4e31bfa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clk/visconti/pll.c
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ static void visconti_pll_add_lookup(struct visconti_pll_provider *ctx,
struct clk_hw *hw_clk,
unsigned int id)
{
if (ctx->clk_data.hws && id)
if (id)
ctx->clk_data.hws[id] = hw_clk;
}

Expand Down

0 comments on commit 4e31bfa

Please sign in to comment.