From cb30701b7482cfe2e03ca6186b7c89043faa1f25 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Mon, 18 Dec 2017 11:02:25 -0200 Subject: [PATCH 1/4] drm/exynos: decon5433: Remove unnecessary platform_get_resource() error check devm_ioremap_resource() already checks if the resource is NULL, so remove the unnecessary platform_get_resource() error check. Cc: Inki Dae Signed-off-by: Fabio Estevam Reviewed-by: Andrzej Hajda Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 6be5b53c3b279..1d509a815d686 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -744,11 +744,6 @@ static int exynos5433_decon_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "cannot find IO resource\n"); - return -ENXIO; - } - ctx->addr = devm_ioremap_resource(dev, res); if (IS_ERR(ctx->addr)) { dev_err(dev, "ioremap failed\n"); From 4f52e55081fb81d6348ecca1f5e2cd45480ca559 Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Tue, 26 Dec 2017 14:07:18 +0100 Subject: [PATCH 2/4] drm/exynos/decon: Move headers from global to local place The DECON headers contain only defines for registers. There are no other drivers using them so this should be put locally to the Exynos DRM driver. Keeping headers local helps managing the code. Suggested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 3 +-- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- .../gpu/drm/exynos/regs-decon5433.h | 0 .../exynos7_decon.h => drivers/gpu/drm/exynos/regs-decon7.h | 3 +-- 4 files changed, 3 insertions(+), 5 deletions(-) rename include/video/exynos5433_decon.h => drivers/gpu/drm/exynos/regs-decon5433.h (100%) rename include/video/exynos7_decon.h => drivers/gpu/drm/exynos/regs-decon7.h (99%) diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 1d509a815d686..1c330f2a7a5d1 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -21,13 +21,12 @@ #include #include -#include