From 70a40ecfcb7d16262cf3ffe5eef4763315a68645 Mon Sep 17 00:00:00 2001 From: Yuiko Oshino Date: Mon, 9 May 2022 11:58:03 -0700 Subject: [PATCH 1/2] net: phy: microchip: add comments for the modified LAN88xx phy ID mask. add comments for the updated LAN88xx phy ID mask in the previous patch. Signed-off-by: Yuiko Oshino Signed-off-by: Jakub Kicinski --- drivers/net/phy/microchip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/phy/microchip.c b/drivers/net/phy/microchip.c index 131caf659ed20..ccecee2524ce6 100644 --- a/drivers/net/phy/microchip.c +++ b/drivers/net/phy/microchip.c @@ -345,6 +345,10 @@ static int lan88xx_config_aneg(struct phy_device *phydev) static struct phy_driver microchip_phy_driver[] = { { .phy_id = 0x0007c132, + /* This mask (0xfffffff2) is to differentiate from + * LAN8742 (phy_id 0x0007c130 and 0x0007c131) + * and allows future phy_id revisions. + */ .phy_id_mask = 0xfffffff2, .name = "Microchip LAN88xx", From b2be075139fa4dad1649edef30963de6315ba237 Mon Sep 17 00:00:00 2001 From: Yuiko Oshino Date: Mon, 9 May 2022 11:58:04 -0700 Subject: [PATCH 2/2] net: phy: smsc: add comments for the LAN8742 phy ID mask. add comments for the LAN8742 phy ID mask in the previous patch. add one missing tab in the LAN8742 phy ID line. Signed-off-by: Yuiko Oshino Signed-off-by: Jakub Kicinski --- drivers/net/phy/smsc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 44fa9e00cc50a..92225d0fc2464 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -484,7 +484,11 @@ static struct phy_driver smsc_phy_driver[] = { .suspend = genphy_suspend, .resume = genphy_resume, }, { - .phy_id = 0x0007c130, /* 0x0007c130 and 0x0007c131 */ + .phy_id = 0x0007c130, /* 0x0007c130 and 0x0007c131 */ + /* This mask (0xfffffff2) is to differentiate from + * LAN88xx (phy_id 0x0007c132) + * and allows future phy_id revisions. + */ .phy_id_mask = 0xfffffff2, .name = "Microchip LAN8742",