Skip to content

Commit

Permalink
net: dsa: let switches specify their tagging protocol
Browse files Browse the repository at this point in the history
In order to support the new DSA device driver model, a dsa_switch should
be able to advertise the type of tagging protocol supported by the
underlying switch device. This also removes constraints on how tagging
can be stacked to each other.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Florian Fainelli authored and David S. Miller committed Mar 6, 2015
1 parent df19719 commit 5929903
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions include/net/dsa.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ struct dsa_switch {
struct dsa_switch_tree *dst;
int index;

/*
* Tagging protocol understood by this switch
*/
enum dsa_tag_protocol tag_protocol;

/*
* Configuration data for this switch.
*/
Expand Down
5 changes: 3 additions & 2 deletions net/dsa/dsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
* switch.
*/
if (dst->cpu_switch == index) {
switch (drv->tag_protocol) {
switch (ds->tag_protocol) {
#ifdef CONFIG_NET_DSA_TAG_DSA
case DSA_TAG_PROTO_DSA:
dst->rcv = dsa_netdev_ops.rcv;
Expand Down Expand Up @@ -255,7 +255,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
goto out;
}

dst->tag_protocol = drv->tag_protocol;
dst->tag_protocol = ds->tag_protocol;
}

/*
Expand Down Expand Up @@ -364,6 +364,7 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
ds->index = index;
ds->pd = pd;
ds->drv = drv;
ds->tag_protocol = drv->tag_protocol;
ds->master_dev = host_dev;

ret = dsa_switch_setup_one(ds, parent);
Expand Down

0 comments on commit 5929903

Please sign in to comment.