Skip to content

Commit

Permalink
xen: Fix page <-> pfn conversion on 32 bit systems
Browse files Browse the repository at this point in the history
Commit 1084b19 (xen: Add Xen specific
page definition) caused a regression in 4.4.

The xen functions to convert between pages and pfns fail due to an
overflow on systems where a physical address may not fit in an
unsigned long (e.g. x86 32 bit PAE systems). Rework the conversion to
avoid overflow. This should also result in simpler object code.

This bug manifested itself as disk corruption with Linux 4.4 when
using blkfront in a Xen HVM x86 32 bit guest with more than 4 GiB of
memory.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Cc: <stable@vger.kernel.org> # 4.4+
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
  • Loading branch information
Ross Lagerwall authored and David Vrabel committed Apr 6, 2016
1 parent 101ecde commit 60901df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/xen/page.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
*/

#define xen_pfn_to_page(xen_pfn) \
((pfn_to_page(((unsigned long)(xen_pfn) << XEN_PAGE_SHIFT) >> PAGE_SHIFT)))
(pfn_to_page((unsigned long)(xen_pfn) >> (PAGE_SHIFT - XEN_PAGE_SHIFT)))
#define page_to_xen_pfn(page) \
(((page_to_pfn(page)) << PAGE_SHIFT) >> XEN_PAGE_SHIFT)
((page_to_pfn(page)) << (PAGE_SHIFT - XEN_PAGE_SHIFT))

#define XEN_PFN_PER_PAGE (PAGE_SIZE / XEN_PAGE_SIZE)

Expand Down

0 comments on commit 60901df

Please sign in to comment.