Skip to content

Commit

Permalink
[PATCH] lockdep: use mutex_lock_nested for bd_mutex to avoid lockdep …
Browse files Browse the repository at this point in the history
…warning

Now that the nesting in blkdev_{get,put} is simpler, adding mutex_lock_nested
is trivial.

Cc: Ingo Molnar <mingo@elte.hu>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
NeilBrown authored and Linus Torvalds committed Dec 8, 2006
1 parent 37be412 commit 6796bf5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/block_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -920,7 +920,7 @@ static int do_open(struct block_device *bdev, struct file *file, int for_part)
}
owner = disk->fops->owner;

mutex_lock(&bdev->bd_mutex);
mutex_lock_nested(&bdev->bd_mutex, for_part);
if (!bdev->bd_openers) {
bdev->bd_disk = disk;
bdev->bd_contains = bdev;
Expand Down Expand Up @@ -1062,7 +1062,7 @@ static int __blkdev_put(struct block_device *bdev, int for_part)
struct gendisk *disk = bdev->bd_disk;
struct block_device *victim = NULL;

mutex_lock(&bdev->bd_mutex);
mutex_lock_nested(&bdev->bd_mutex, for_part);
lock_kernel();
if (for_part)
bdev->bd_part_count--;
Expand Down

0 comments on commit 6796bf5

Please sign in to comment.