Skip to content

Commit

Permalink
ASOC: SOF: Intel: hda-codec: move unused label to correct position
Browse files Browse the repository at this point in the history
commit 11ec0ed upstream.

Cppcheck reports the following warning:

sound/soc/sof/intel/hda-codec.c:191:1: style: Label 'error' is not
used. [unusedLabel]

This label is indeed only used conditionally, move it where it's
actually used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813175839.59422-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Pierre-Louis Bossart authored and Greg Kroah-Hartman committed Nov 5, 2020
1 parent 85b047c commit 689d2a4
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions sound/soc/sof/intel/hda-codec.c
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address,
}

return ret;

error:
snd_hdac_ext_bus_device_exit(hdev);
return -ENOENT;

#else
hdev = devm_kzalloc(sdev->dev, sizeof(*hdev), GFP_KERNEL);
if (!hdev)
Expand Down

0 comments on commit 689d2a4

Please sign in to comment.