Skip to content

Commit

Permalink
mmc: dw_mmc: exynos: Obviously always return success in remove callback
Browse files Browse the repository at this point in the history
dw_mci_pltfm_remove() returns 0 unconditionally and returning an error
in a platform remove callback isn't very sensible. (The only effect of
the latter is that the device core emits a generic warning and then
removes the device anyhow.)

So return 0 unconditionally to make it obvious there is no error
forwarded to the upper layers.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220610211257.102071-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Uwe Kleine-König authored and Ulf Hansson committed Jul 12, 2022
1 parent c3c0ed7 commit 68eab51
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/mmc/host/dw_mmc-exynos.c
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,9 @@ static int dw_mci_exynos_remove(struct platform_device *pdev)
pm_runtime_set_suspended(&pdev->dev);
pm_runtime_put_noidle(&pdev->dev);

return dw_mci_pltfm_remove(pdev);
dw_mci_pltfm_remove(pdev);

return 0;
}

static const struct dev_pm_ops dw_mci_exynos_pmops = {
Expand Down

0 comments on commit 68eab51

Please sign in to comment.