From 6955bfef8f2b5b2f4e35577b708967bd986d3aa3 Mon Sep 17 00:00:00 2001 From: Namjae Jeon Date: Fri, 21 Mar 2025 22:05:39 +0900 Subject: [PATCH] ksmbd: use ib_device_get_netdev() instead of calling ops.get_netdev ULPs are not supposed to call to ops.* directly. Suggested-by: Leon Romanovsky Reviewed-by: Leon Romanovsky Signed-off-by: Namjae Jeon Signed-off-by: Steve French --- fs/smb/server/transport_rdma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/smb/server/transport_rdma.c b/fs/smb/server/transport_rdma.c index 9837a41641ce..4998df04ab95 100644 --- a/fs/smb/server/transport_rdma.c +++ b/fs/smb/server/transport_rdma.c @@ -2142,8 +2142,7 @@ static int smb_direct_ib_client_add(struct ib_device *ib_dev) if (ib_dev->node_type != RDMA_NODE_IB_CA) smb_direct_port = SMB_DIRECT_PORT_IWARP; - if (!ib_dev->ops.get_netdev || - !rdma_frwr_is_supported(&ib_dev->attrs)) + if (!rdma_frwr_is_supported(&ib_dev->attrs)) return 0; smb_dev = kzalloc(sizeof(*smb_dev), KSMBD_DEFAULT_GFP); @@ -2243,8 +2242,7 @@ bool ksmbd_rdma_capable_netdev(struct net_device *netdev) for (i = 0; i < smb_dev->ib_dev->phys_port_cnt; i++) { struct net_device *ndev; - ndev = smb_dev->ib_dev->ops.get_netdev(smb_dev->ib_dev, - i + 1); + ndev = ib_device_get_netdev(smb_dev->ib_dev, i + 1); if (!ndev) continue;