Skip to content

Commit

Permalink
target: go through normal processing for zero-length REQUEST_SENSE
Browse files Browse the repository at this point in the history
Now that spc_emulate_request_sense has been taught to process zero-length
REQUEST SENSE correctly, drop the special handling of unit attention
conditions from transport_generic_new_cmd.  However, for now REQUEST SENSE
will be the only command that goes through emulation for zero lengths.

(nab: Fix up zero-length check in transport_generic_new_cmd)

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Paolo Bonzini authored and Nicholas Bellinger committed Sep 7, 2012
1 parent 32a8811 commit 6abbdf3
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions drivers/target/target_core_transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -2306,20 +2306,13 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
* away.
*/
if (!cmd->data_length &&
(cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
cmd->t_task_cdb[0] == REPORT_LUNS) {
cmd->t_task_cdb[0] != REQUEST_SENSE &&
cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) {
spin_lock_irq(&cmd->t_state_lock);
cmd->t_state = TRANSPORT_COMPLETE;
cmd->transport_state |= CMD_T_ACTIVE;
spin_unlock_irq(&cmd->t_state_lock);

if (cmd->t_task_cdb[0] == REQUEST_SENSE) {
u8 ua_asc = 0, ua_ascq = 0;

core_scsi3_ua_clear_for_request_sense(cmd,
&ua_asc, &ua_ascq);
}

INIT_WORK(&cmd->work, target_complete_ok_work);
queue_work(target_completion_wq, &cmd->work);
return 0;
Expand Down

0 comments on commit 6abbdf3

Please sign in to comment.