Skip to content

Commit

Permalink
ipv6: Remove rt6_check_dev
Browse files Browse the repository at this point in the history
rt6_check_dev is a simpler helper with only 1 caller. Fold the code
into rt6_score_route.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Ahern authored and David S. Miller committed Apr 11, 2019
1 parent 1ba9a89 commit 6e1809a
Showing 1 changed file with 4 additions and 11 deletions.
15 changes: 4 additions & 11 deletions net/ipv6/route.c
Original file line number Diff line number Diff line change
Expand Up @@ -580,15 +580,6 @@ static inline void rt6_probe(struct fib6_info *rt)
/*
* Default Router Selection (RFC 2461 6.3.6)
*/
static inline int rt6_check_dev(struct fib6_info *rt, int oif)
{
const struct net_device *dev = rt->fib6_nh.fib_nh_dev;

if (!oif || dev->ifindex == oif)
return 2;
return 0;
}

static enum rt6_nud_state rt6_check_neigh(const struct fib6_nh *fib6_nh)
{
enum rt6_nud_state ret = RT6_NUD_FAIL_HARD;
Expand Down Expand Up @@ -620,9 +611,11 @@ static enum rt6_nud_state rt6_check_neigh(const struct fib6_nh *fib6_nh)
static int rt6_score_route(struct fib6_info *rt, int oif, int strict)
{
struct fib6_nh *nh = &rt->fib6_nh;
int m;
int m = 0;

if (!oif || nh->fib_nh_dev->ifindex == oif)
m = 2;

m = rt6_check_dev(rt, oif);
if (!m && (strict & RT6_LOOKUP_F_IFACE))
return RT6_NUD_FAIL_HARD;
#ifdef CONFIG_IPV6_ROUTER_PREF
Expand Down

0 comments on commit 6e1809a

Please sign in to comment.