Skip to content

Commit

Permalink
mac802154: llsec: fix incorrect lock pairing
Browse files Browse the repository at this point in the history
In encrypt, sec->lock is taken with read_lock_bh, so in the error path,
we must read_unlock_bh.

Signed-off-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Phoebe Buckheister authored and David S. Miller committed May 22, 2014
1 parent 68bc74f commit 6f3eabc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mac802154/llsec.c
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ int mac802154_llsec_encrypt(struct mac802154_llsec *sec, struct sk_buff *skb)
return rc < 0 ? rc : 0;

fail_read:
read_unlock(&sec->lock);
read_unlock_bh(&sec->lock);
fail:
rcu_read_unlock();
return rc;
Expand Down

0 comments on commit 6f3eabc

Please sign in to comment.