Skip to content

Commit

Permalink
Input: navpoint - pass correct pointer to free_irq()
Browse files Browse the repository at this point in the history
free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Lars-Peter Clausen authored and Dmitry Torokhov committed May 23, 2013
1 parent 139097a commit 737f644
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/input/mouse/navpoint.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ static int navpoint_probe(struct platform_device *pdev)
return 0;

err_free_irq:
free_irq(ssp->irq, &pdev->dev);
free_irq(ssp->irq, navpoint);
err_free_mem:
input_free_device(input);
kfree(navpoint);
Expand Down

0 comments on commit 737f644

Please sign in to comment.