Skip to content

Commit

Permalink
libata: make AHCI_XGENE depend on PHY_XGENE
Browse files Browse the repository at this point in the history
AHCI_XGENE is only applicable on ARM64 but it can also be enabled for
compile testing; however, AHCI_XGENE selects PHY_XGENE which has other
arch specific dependencies.  This leads to the following warning when
enabling it on other archs for compile testing.

  warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
  dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))

Selecting a config option which itself has dependencies can easily
lead to broken configurations.  For now, let's just make AHCI_XGENE
depend on PHY_XGENE which has all the necessary dependencies already.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Loc Ho <lho@apm.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
  • Loading branch information
Tejun Heo committed Apr 2, 2014
1 parent b33ce44 commit 74c03eb
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/ata/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ config AHCI_SUNXI

config AHCI_XGENE
tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
depends on ARM64 || COMPILE_TEST
select PHY_XGENE
depends on PHY_XGENE
help
This option enables support for APM X-Gene SoC SATA host controller.

Expand Down

0 comments on commit 74c03eb

Please sign in to comment.