Skip to content

Commit

Permalink
batman-adv: remove unused parameters
Browse files Browse the repository at this point in the history
Some function parameters are obsolete now and can be removed.

Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
  • Loading branch information
Simon Wunderlich authored and Sven Eckelmann committed Jan 31, 2011
1 parent ae361ce commit 74ef115
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
2 changes: 1 addition & 1 deletion net/batman-adv/originator.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ static bool purge_orig_node(struct bat_priv *bat_priv,
orig_node->hna_buff_len);
/* update bonding candidates, we could have lost
* some candidates. */
update_bonding_candidates(bat_priv, orig_node);
update_bonding_candidates(orig_node);
}
}

Expand Down
15 changes: 6 additions & 9 deletions net/batman-adv/routing.c
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,7 @@ static char count_real_packets(struct ethhdr *ethhdr,
}

/* copy primary address for bonding */
static void mark_bonding_address(struct bat_priv *bat_priv,
struct orig_node *orig_node,
static void mark_bonding_address(struct orig_node *orig_node,
struct orig_node *orig_neigh_node,
struct batman_packet *batman_packet)

Expand All @@ -447,8 +446,7 @@ static void mark_bonding_address(struct bat_priv *bat_priv,
}

/* mark possible bond.candidates in the neighbor list */
void update_bonding_candidates(struct bat_priv *bat_priv,
struct orig_node *orig_node)
void update_bonding_candidates(struct orig_node *orig_node)
{
int candidates;
int interference_candidate;
Expand Down Expand Up @@ -730,9 +728,8 @@ void receive_bat_packet(struct ethhdr *ethhdr,
update_orig(bat_priv, orig_node, ethhdr, batman_packet,
if_incoming, hna_buff, hna_buff_len, is_duplicate);

mark_bonding_address(bat_priv, orig_node,
orig_neigh_node, batman_packet);
update_bonding_candidates(bat_priv, orig_node);
mark_bonding_address(orig_node, orig_neigh_node, batman_packet);
update_bonding_candidates(orig_node);

/* is single hop (direct) neighbor */
if (is_single_hop_neigh) {
Expand Down Expand Up @@ -866,7 +863,7 @@ static int recv_my_icmp_packet(struct bat_priv *bat_priv,
}

static int recv_icmp_ttl_exceeded(struct bat_priv *bat_priv,
struct sk_buff *skb, size_t icmp_len)
struct sk_buff *skb)
{
struct orig_node *orig_node;
struct icmp_packet *icmp_packet;
Expand Down Expand Up @@ -978,7 +975,7 @@ int recv_icmp_packet(struct sk_buff *skb, struct batman_if *recv_if)

/* TTL exceeded */
if (icmp_packet->ttl < 2)
return recv_icmp_ttl_exceeded(bat_priv, skb, hdr_size);
return recv_icmp_ttl_exceeded(bat_priv, skb);

ret = NET_RX_DROP;

Expand Down
3 changes: 1 addition & 2 deletions net/batman-adv/routing.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ int recv_vis_packet(struct sk_buff *skb, struct batman_if *recv_if);
int recv_bat_packet(struct sk_buff *skb, struct batman_if *recv_if);
struct neigh_node *find_router(struct bat_priv *bat_priv,
struct orig_node *orig_node, struct batman_if *recv_if);
void update_bonding_candidates(struct bat_priv *bat_priv,
struct orig_node *orig_node);
void update_bonding_candidates(struct orig_node *orig_node);

#endif /* _NET_BATMAN_ADV_ROUTING_H_ */
4 changes: 2 additions & 2 deletions net/batman-adv/send.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static unsigned long own_send_time(struct bat_priv *bat_priv)
}

/* when do we schedule a forwarded packet to be sent */
static unsigned long forward_send_time(struct bat_priv *bat_priv)
static unsigned long forward_send_time(void)
{
return jiffies + msecs_to_jiffies(random32() % (JITTER/2));
}
Expand Down Expand Up @@ -356,7 +356,7 @@ void schedule_forward_packet(struct orig_node *orig_node,
else
batman_packet->flags &= ~DIRECTLINK;

send_time = forward_send_time(bat_priv);
send_time = forward_send_time();
add_bat_packet_to_list(bat_priv,
(unsigned char *)batman_packet,
sizeof(struct batman_packet) + hna_buff_len,
Expand Down

0 comments on commit 74ef115

Please sign in to comment.