Skip to content

Commit

Permalink
cw1200: no need to check return value of debugfs_create functions
Browse files Browse the repository at this point in the history
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Solomon Peachy <pizza@shaftnet.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
  • Loading branch information
Greg Kroah-Hartman authored and Kalle Valo committed Feb 1, 2019
1 parent b089e69 commit 80f4c5e
Showing 1 changed file with 6 additions and 20 deletions.
26 changes: 6 additions & 20 deletions drivers/net/wireless/st/cw1200/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -371,28 +371,14 @@ int cw1200_debug_init(struct cw1200_common *priv)

d->debugfs_phy = debugfs_create_dir("cw1200",
priv->hw->wiphy->debugfsdir);
if (!d->debugfs_phy)
goto err;

if (!debugfs_create_file("status", 0400, d->debugfs_phy,
priv, &cw1200_status_fops))
goto err;

if (!debugfs_create_file("counters", 0400, d->debugfs_phy,
priv, &cw1200_counters_fops))
goto err;

if (!debugfs_create_file("wsm_dumps", 0200, d->debugfs_phy,
priv, &fops_wsm_dumps))
goto err;
debugfs_create_file("status", 0400, d->debugfs_phy, priv,
&cw1200_status_fops);
debugfs_create_file("counters", 0400, d->debugfs_phy, priv,
&cw1200_counters_fops);
debugfs_create_file("wsm_dumps", 0200, d->debugfs_phy, priv,
&fops_wsm_dumps);

return 0;

err:
priv->debug = NULL;
debugfs_remove_recursive(d->debugfs_phy);
kfree(d);
return ret;
}

void cw1200_debug_release(struct cw1200_common *priv)
Expand Down

0 comments on commit 80f4c5e

Please sign in to comment.