Skip to content

Commit

Permalink
gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()
Browse files Browse the repository at this point in the history
It's not necessary to remove gpio_chip which added with
devm_gpiochip_add_data().

Fixes: b868db9 ("gpio: tqmx86: Add GPIO from for this IO controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
Wei Yongjun authored and Linus Walleij committed Feb 9, 2019
1 parent 2a0b0a5 commit 96be65d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpio/gpio-tqmx86.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
IRQ_TYPE_EDGE_BOTH);
if (ret) {
dev_err(dev, "Could not add irq chip\n");
goto out_remove;
goto out_pm_dis;
}

gpiochip_set_chained_irqchip(chip, irq_chip,
Expand All @@ -309,8 +309,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)

return 0;

out_remove:
gpiochip_remove(&gpio->chip);
out_pm_dis:
pm_runtime_disable(&pdev->dev);

Expand Down

0 comments on commit 96be65d

Please sign in to comment.