Skip to content

Commit

Permalink
x86: make APIC_init_uniprocessor() more like smp_prepare_cpus()
Browse files Browse the repository at this point in the history
Impact: cleanup

1. move localise_nmi_watchdog() later
2. change setup_boot_APIC_clock() to setup_boot_clock() for 64-bit

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Yinghai Lu authored and Ingo Molnar committed Feb 16, 2009
1 parent 3bd25d0 commit 98c061b
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions arch/x86/kernel/apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1649,32 +1649,28 @@ int __init APIC_init_uniprocessor(void)
#ifdef CONFIG_X86_IO_APIC
/*
* Now enable IO-APICs, actually call clear_IO_APIC
* We need clear_IO_APIC before enabling vector on BP
* We need clear_IO_APIC before enabling error vector
*/
if (!skip_ioapic_setup && nr_ioapics)
enable_IO_APIC();

if (!smp_found_config || skip_ioapic_setup || !nr_ioapics)
localise_nmi_watchdog();
#else
localise_nmi_watchdog();
#endif

end_local_APIC_setup();

#ifdef CONFIG_X86_IO_APIC
if (smp_found_config && !skip_ioapic_setup && nr_ioapics)
setup_IO_APIC();
# ifdef CONFIG_X86_64
else
else {
nr_ioapics = 0;
# endif
localise_nmi_watchdog();
}
#else
localise_nmi_watchdog();
#endif

setup_boot_clock();
#ifdef CONFIG_X86_64
setup_boot_APIC_clock();
check_nmi_watchdog();
#else
setup_boot_clock();
#endif

return 0;
Expand Down

0 comments on commit 98c061b

Please sign in to comment.