Skip to content

Commit

Permalink
drm/i915: Extract opregion vbt presence check
Browse files Browse the repository at this point in the history
We want to later change intel_opregion_get_vbt to duplicate the vbt
memory if present, which would be an overkill when we just want to
peek into the presence of opregion vbt. Carve out the presence check
into its own function to use in places where only the presence of vbt
is required.

Suggested-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240228213235.2495611-5-radhakrishna.sripada@intel.com
  • Loading branch information
Radhakrishna Sripada authored and Jani Nikula committed Mar 11, 2024
1 parent d962f0a commit 9d9bb71
Showing 3 changed files with 12 additions and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/gpu/drm/i915/display/intel_bios.c
Original file line number Diff line number Diff line change
@@ -3414,8 +3414,7 @@ bool intel_bios_is_lvds_present(struct drm_i915_private *i915, u8 *i2c_pin)
* additional data. Trust that if the VBT was written into
* the OpRegion then they have validated the LVDS's existence.
*/
if (intel_opregion_get_vbt(i915, NULL))
return true;
return intel_opregion_vbt_present(i915);
}

return false;
10 changes: 10 additions & 0 deletions drivers/gpu/drm/i915/display/intel_opregion.c
Original file line number Diff line number Diff line change
@@ -1131,6 +1131,16 @@ const struct drm_edid *intel_opregion_get_edid(struct intel_connector *intel_con
return drm_edid;
}

bool intel_opregion_vbt_present(struct drm_i915_private *i915)
{
struct intel_opregion *opregion = i915->display.opregion;

if (!opregion || !opregion->vbt)
return false;

return true;
}

const void *intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size)
{
struct intel_opregion *opregion = i915->display.opregion;
1 change: 1 addition & 0 deletions drivers/gpu/drm/i915/display/intel_opregion.h
Original file line number Diff line number Diff line change
@@ -53,6 +53,7 @@ int intel_opregion_notify_adapter(struct drm_i915_private *dev_priv,
int intel_opregion_get_panel_type(struct drm_i915_private *dev_priv);
const struct drm_edid *intel_opregion_get_edid(struct intel_connector *connector);

bool intel_opregion_vbt_present(struct drm_i915_private *i915);
const void *intel_opregion_get_vbt(struct drm_i915_private *i915, size_t *size);

bool intel_opregion_headless_sku(struct drm_i915_private *i915);

0 comments on commit 9d9bb71

Please sign in to comment.