Skip to content

Commit

Permalink
iio: inkern: make a best effort on offset calculation
Browse files Browse the repository at this point in the history
commit ca85123 upstream.

iio_convert_raw_to_processed_unlocked() assumes the offset is an
integer. Make a best effort to get a valid offset value for fractional
cases without breaking implicit truncations.

Fixes: 48e44ce ("iio:inkern: Add function to read the processed value")
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
Reviewed-by: Peter Rosin <peda@axentia.se>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220108205319.2046348-4-liambeguin@gmail.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Liam Beguin authored and Greg Kroah-Hartman committed Apr 8, 2022
1 parent 19e5334 commit 9f0cd81
Showing 1 changed file with 27 additions and 5 deletions.
32 changes: 27 additions & 5 deletions drivers/iio/inkern.c
Original file line number Diff line number Diff line change
Expand Up @@ -561,13 +561,35 @@ EXPORT_SYMBOL_GPL(iio_read_channel_average_raw);
static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan,
int raw, int *processed, unsigned int scale)
{
int scale_type, scale_val, scale_val2, offset;
int scale_type, scale_val, scale_val2;
int offset_type, offset_val, offset_val2;
s64 raw64 = raw;
int ret;

ret = iio_channel_read(chan, &offset, NULL, IIO_CHAN_INFO_OFFSET);
if (ret >= 0)
raw64 += offset;
offset_type = iio_channel_read(chan, &offset_val, &offset_val2,
IIO_CHAN_INFO_OFFSET);
if (offset_type >= 0) {
switch (offset_type) {
case IIO_VAL_INT:
break;
case IIO_VAL_INT_PLUS_MICRO:
case IIO_VAL_INT_PLUS_NANO:
/*
* Both IIO_VAL_INT_PLUS_MICRO and IIO_VAL_INT_PLUS_NANO
* implicitely truncate the offset to it's integer form.
*/
break;
case IIO_VAL_FRACTIONAL:
offset_val /= offset_val2;
break;
case IIO_VAL_FRACTIONAL_LOG2:
offset_val >>= offset_val2;
break;
default:
return -EINVAL;
}

raw64 += offset_val;
}

scale_type = iio_channel_read(chan, &scale_val, &scale_val2,
IIO_CHAN_INFO_SCALE);
Expand Down

0 comments on commit 9f0cd81

Please sign in to comment.