Skip to content

Commit

Permalink
HID: hidraw: Fix returning EPOLLOUT from hidraw_poll
Browse files Browse the repository at this point in the history
When polling a connected /dev/hidrawX device, it is useful to get the
EPOLLOUT when writing is possible. Since writing is possible as soon as
the device is connected, always return it.

Right now EPOLLOUT is only returned when there are also input reports
are available. This works if devices start sending reports when
connected, but some HID devices might need an output report first before
sending any input reports. This change will allow using EPOLLOUT here as
well.

Fixes: 378b803 ("hidraw: Return EPOLLOUT from hidraw_poll")
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Marcel Holtmann authored and Jiri Kosina committed Dec 9, 2019
1 parent d004701 commit 9f3b61d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/hid/hidraw.c
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,10 @@ static __poll_t hidraw_poll(struct file *file, poll_table *wait)

poll_wait(file, &list->hidraw->wait, wait);
if (list->head != list->tail)
return EPOLLIN | EPOLLRDNORM | EPOLLOUT;
return EPOLLIN | EPOLLRDNORM;
if (!list->hidraw->exist)
return EPOLLERR | EPOLLHUP;
return 0;
return EPOLLOUT | EPOLLWRNORM;
}

static int hidraw_open(struct inode *inode, struct file *file)
Expand Down

0 comments on commit 9f3b61d

Please sign in to comment.