Skip to content

Commit

Permalink
crypto: hisilicon/trng - replace atomic_add_return()
Browse files Browse the repository at this point in the history
a set of atomic_inc_return() looks more neater

Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Yejune Deng authored and Herbert Xu committed Dec 11, 2020
1 parent 8857433 commit a320dc2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/crypto/hisilicon/trng/trng.c
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,12 @@ static int hisi_trng_probe(struct platform_device *pdev)
}

hisi_trng_add_to_list(trng);
if (atomic_add_return(1, &trng_active_devs) == 1) {
if (atomic_inc_return(&trng_active_devs) == 1) {
ret = crypto_register_rng(&hisi_trng_alg);
if (ret) {
dev_err(&pdev->dev,
"failed to register crypto(%d)\n", ret);
atomic_sub_return(1, &trng_active_devs);
atomic_dec_return(&trng_active_devs);
goto err_remove_from_list;
}
}
Expand All @@ -289,7 +289,7 @@ static int hisi_trng_probe(struct platform_device *pdev)
return ret;

err_crypto_unregister:
if (atomic_sub_return(1, &trng_active_devs) == 0)
if (atomic_dec_return(&trng_active_devs) == 0)
crypto_unregister_rng(&hisi_trng_alg);

err_remove_from_list:
Expand All @@ -305,7 +305,7 @@ static int hisi_trng_remove(struct platform_device *pdev)
while (hisi_trng_del_from_list(trng))
;

if (atomic_sub_return(1, &trng_active_devs) == 0)
if (atomic_dec_return(&trng_active_devs) == 0)
crypto_unregister_rng(&hisi_trng_alg);

return 0;
Expand Down

0 comments on commit a320dc2

Please sign in to comment.