Skip to content

Commit

Permalink
phy: miphy365x: Fix off-by-one error
Browse files Browse the repository at this point in the history
We index the RX/TX speed select values in the following way:

  rx_tx_spd[miphy_phy->sata_gen];

However rx_tx_spd[] starts at index zero and the SATA_GENx's start
at one.  In this patch we pad out the first element in rx_tx_spd[]
in an attempt to realign the values.

Cc: Alexandre Torgue <alexandre.torgue@st.com>
Reported-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
  • Loading branch information
Lee Jones authored and Kishon Vijay Abraham I committed Sep 12, 2014
1 parent fbb1a77 commit a6cc1b9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/phy/phy-miphy365x.c
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ enum miphy_sata_gen {
};

static u8 rx_tx_spd[] = {
0, /* GEN0 doesn't exist. */
TX_SPDSEL_GEN1_VAL | RX_SPDSEL_GEN1_VAL,
TX_SPDSEL_GEN2_VAL | RX_SPDSEL_GEN2_VAL,
TX_SPDSEL_GEN3_VAL | RX_SPDSEL_GEN3_VAL
Expand Down

0 comments on commit a6cc1b9

Please sign in to comment.