Skip to content

Commit

Permalink
selftests: openat2: Skip testcases that fail with EOPNOTSUPP
Browse files Browse the repository at this point in the history
Skip testcases that fail since the requested valid flags combination is not
supported by the underlying filesystem.

Cc: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
  • Loading branch information
Cristian Marussi authored and Shuah Khan committed Jan 27, 2022
1 parent ea33967 commit ac9e0a2
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion tools/testing/selftests/openat2/openat2_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,16 @@ void test_openat2_flags(void)
unlink(path);

fd = sys_openat2(AT_FDCWD, path, &test->how);
if (fd < 0 && fd == -EOPNOTSUPP) {
/*
* Skip the testcase if it failed because not supported
* by FS. (e.g. a valid O_TMPFILE combination on NFS)
*/
ksft_test_result_skip("openat2 with %s fails with %d (%s)\n",
test->name, fd, strerror(-fd));
goto next;
}

if (test->err >= 0)
failed = (fd < 0);
else
Expand Down Expand Up @@ -303,7 +313,7 @@ void test_openat2_flags(void)
else
resultfn("openat2 with %s fails with %d (%s)\n",
test->name, test->err, strerror(-test->err));

next:
free(fdpath);
fflush(stdout);
}
Expand Down

0 comments on commit ac9e0a2

Please sign in to comment.