Skip to content

Commit

Permalink
sched: Fix sched_policy < 0 comparison
Browse files Browse the repository at this point in the history
attr.sched_policy is u32, therefore a comparison against < 0 is never true.
Fix this by casting sched_policy to int.

This issue was reported by coverity CID 1219934.

Fixes: dbdb227 ("sched: Disallow sched_attr::sched_policy < 0")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1401741514-7045-1-git-send-email-richard@nod.at
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Richard Weinberger authored and Ingo Molnar committed Jun 5, 2014
1 parent e9dd685 commit b14ed2c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/sched/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -3685,7 +3685,7 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr,
if (retval)
return retval;

if (attr.sched_policy < 0)
if ((int)attr.sched_policy < 0)
return -EINVAL;

rcu_read_lock();
Expand Down

0 comments on commit b14ed2c

Please sign in to comment.