Skip to content

Commit

Permalink
extcon: Fix the checkpatch warning and minor coding style issue
Browse files Browse the repository at this point in the history
This patch clean up the extcon core driver by fixing the checkpatch warning
and minor coding style issue.

Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
  • Loading branch information
Chanwoo Choi committed May 19, 2015
1 parent 707d755 commit b9ec23c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
10 changes: 5 additions & 5 deletions drivers/extcon/extcon.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* drivers/extcon/extcon_class.c
* drivers/extcon/extcon.c - External Connector (extcon) framework.
*
* External connector (extcon) class driver
*
Expand All @@ -19,8 +19,7 @@
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
*/
*/

#include <linux/module.h>
#include <linux/types.h>
Expand Down Expand Up @@ -469,7 +468,6 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj,
ret = raw_notifier_chain_register(&obj->edev->nh,
&obj->internal_nb);
spin_unlock_irqrestore(&obj->edev->lock, flags);
return ret;
} else {
struct class_dev_iter iter;
struct extcon_dev *extd;
Expand All @@ -489,8 +487,10 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj,
cable_name, nb);
}

return -ENODEV;
ret = -ENODEV;
}

return ret;
}
EXPORT_SYMBOL_GPL(extcon_register_interest);

Expand Down
7 changes: 4 additions & 3 deletions include/linux/extcon.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ struct extcon_cable;
* @state: Attach/detach state of this extcon. Do not provide at
* register-time.
* @nh: Notifier for the state change events from this extcon
* @entry: To support list of extcon devices so that users can search
* for extcon devices based on the extcon name.
* @entry: To support list of extcon devices so that users can
* search for extcon devices based on the extcon name.
* @lock:
* @max_supported: Internal value to store the number of cables.
* @extcon_dev_type: Device_type struct to provide attribute_groups
Expand Down Expand Up @@ -258,7 +258,8 @@ extern int extcon_unregister_notifier(struct extcon_dev *edev,
* Following API get the extcon device from devicetree.
* This function use phandle of devicetree to get extcon device directly.
*/
extern struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index);
extern struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev,
int index);

/* Following API to get information of extcon device */
extern const char *extcon_get_edev_name(struct extcon_dev *edev);
Expand Down

0 comments on commit b9ec23c

Please sign in to comment.