Skip to content

Commit

Permalink
rust: types: Make Opaque::get const
Browse files Browse the repository at this point in the history
To support a potential usage:

    static foo: Opaque<Foo> = ..; // Or defined in an extern block.

    ...

    fn bar() {
        let ptr = foo.get();
    }

`Opaque::get` need to be `const`, otherwise compiler will complain
because calls on statics are limited to const functions.

Also `Opaque::get` should be naturally `const` since it's a composition
of two `const` functions: `UnsafeCell::get` and `ptr::cast`.

Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Wedson Almeida Filho <walmeida@microsoft.com>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Link: https://lore.kernel.org/r/20240401214543.1242286-1-boqun.feng@gmail.com
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
  • Loading branch information
Boqun Feng authored and Miguel Ojeda committed May 5, 2024
1 parent 2c10928 commit be2ca1e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rust/kernel/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ impl<T> Opaque<T> {
}

/// Returns a raw pointer to the opaque data.
pub fn get(&self) -> *mut T {
pub const fn get(&self) -> *mut T {
UnsafeCell::get(&self.value).cast::<T>()
}

Expand Down

0 comments on commit be2ca1e

Please sign in to comment.