Skip to content

Commit

Permalink
net: irda: remove unnecessary platform_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d06
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed May 28, 2013
1 parent dfd93c9 commit bf3a33c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion drivers/net/irda/bfin_sir.c
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,6 @@ static int bfin_sir_remove(struct platform_device *pdev)
kfree(self->rx_buff.head);
free_netdev(dev);
kfree(sir_port);
platform_set_drvdata(pdev, NULL);

return 0;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/irda/sh_irda.c
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,6 @@ static int sh_irda_remove(struct platform_device *pdev)
sh_irda_remove_iobuf(self);
iounmap(self->membase);
free_netdev(ndev);
platform_set_drvdata(pdev, NULL);

return 0;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/net/irda/sh_sir.c
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,6 @@ static int sh_sir_remove(struct platform_device *pdev)
sh_sir_remove_iobuf(self);
iounmap(self->membase);
free_netdev(ndev);
platform_set_drvdata(pdev, NULL);

return 0;
}
Expand Down

0 comments on commit bf3a33c

Please sign in to comment.