Skip to content

Commit

Permalink
netlink: simplify nfnetlink_bind
Browse files Browse the repository at this point in the history
Remove duplicity and simplify code flow by moving the rcu_read_unlock() above
the condition and let the flow control exit naturally at the end of the
function.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Richard Guy Briggs authored and David S. Miller committed Apr 23, 2014
1 parent 4cd3675 commit bfe4bc7
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions net/netfilter/nfnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -407,12 +407,9 @@ static void nfnetlink_bind(int group)

rcu_read_lock();
ss = nfnetlink_get_subsys(type);
if (!ss) {
rcu_read_unlock();
request_module("nfnetlink-subsys-%d", type);
return;
}
rcu_read_unlock();
if (!ss)
request_module("nfnetlink-subsys-%d", type);
}
#endif

Expand Down

0 comments on commit bfe4bc7

Please sign in to comment.