Skip to content

Commit

Permalink
crypto: hisilicon - cleanup warning in qm_get_qos_value()
Browse files Browse the repository at this point in the history
Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value
        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting
*val.  So check ret before checking *val.

Fixes: 72b010d ("crypto: hisilicon/qm - supports writing QoS int the host")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Tom Rix authored and Herbert Xu committed Dec 31, 2021
1 parent 304b4ac commit c5d692a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/crypto/hisilicon/qm.c
Original file line number Diff line number Diff line change
Expand Up @@ -4394,7 +4394,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf,
return -EINVAL;

ret = qm_qos_value_init(val_buf, val);
if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {
pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");
return -EINVAL;
}
Expand Down

0 comments on commit c5d692a

Please sign in to comment.