Skip to content

Commit

Permalink
drm: adv7511: Add has_dsi variable to struct adv7511_chip_info
Browse files Browse the repository at this point in the history 
The ADV7533 and ADV7535 have DSI support. Add a variable has_dsi to
struct adv7511_chip_info for handling configuration related to DSI.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230830142358.275459-7-biju.das.jz@bp.renesas.com
  • Loading branch information
Biju Das authored and Robert Foss committed Oct 16, 2023
1 parent 8d6cf57 commit c755512
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/bridge/adv7511/adv7511.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ struct adv7511_chip_info {
const char * const *supply_names;
unsigned int num_supplies;
unsigned int reg_cec_offset;
bool has_dsi;
};

struct adv7511 {
Expand Down
10 changes: 6 additions & 4 deletions drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ static void adv7511_power_on(struct adv7511 *adv7511)
*/
regcache_sync(adv7511->regmap);

if (adv7511->info->type == ADV7533 || adv7511->info->type == ADV7535)
if (adv7511->info->has_dsi)
adv7533_dsi_power_on(adv7511);
adv7511->powered = true;
}
Expand All @@ -397,7 +397,7 @@ static void __adv7511_power_off(struct adv7511 *adv7511)
static void adv7511_power_off(struct adv7511 *adv7511)
{
__adv7511_power_off(adv7511);
if (adv7511->info->type == ADV7533 || adv7511->info->type == ADV7535)
if (adv7511->info->has_dsi)
adv7533_dsi_power_off(adv7511);
adv7511->powered = false;
}
Expand Down Expand Up @@ -921,7 +921,7 @@ static enum drm_mode_status adv7511_bridge_mode_valid(struct drm_bridge *bridge,
{
struct adv7511 *adv = bridge_to_adv7511(bridge);

if (adv->info->type == ADV7533 || adv->info->type == ADV7535)
if (adv->info->has_dsi)
return adv7533_mode_valid(adv, mode);
else
return adv7511_mode_valid(adv, mode);
Expand Down Expand Up @@ -1311,7 +1311,7 @@ static int adv7511_probe(struct i2c_client *i2c)

adv7511_audio_init(dev, adv7511);

if (adv7511->info->type == ADV7533 || adv7511->info->type == ADV7535) {
if (adv7511->info->has_dsi) {
ret = adv7533_attach_dsi(adv7511);
if (ret)
goto err_unregister_audio;
Expand Down Expand Up @@ -1367,6 +1367,7 @@ static const struct adv7511_chip_info adv7533_chip_info = {
.supply_names = adv7533_supply_names,
.num_supplies = ARRAY_SIZE(adv7533_supply_names),
.reg_cec_offset = ADV7533_REG_CEC_OFFSET,
.has_dsi = true,
};

static const struct adv7511_chip_info adv7535_chip_info = {
Expand All @@ -1376,6 +1377,7 @@ static const struct adv7511_chip_info adv7535_chip_info = {
.supply_names = adv7533_supply_names,
.num_supplies = ARRAY_SIZE(adv7533_supply_names),
.reg_cec_offset = ADV7533_REG_CEC_OFFSET,
.has_dsi = true,
};

static const struct i2c_device_id adv7511_i2c_ids[] = {
Expand Down

0 comments on commit c755512

Please sign in to comment.