Skip to content

Commit

Permalink
libata-sff: kill unused prototype and make ata_dev_select() static
Browse files Browse the repository at this point in the history
ata_irq_on() was renamed to ata_sff_irq_on() and exported a while ago
but prototype for the original function lingered in
drivers/ata/libata.h.  Kill it.  Also, ata_dev_select() is only used
inside drivers/ata/libata-sff.c.  Make it static.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Tejun Heo authored and Jeff Garzik committed May 15, 2010
1 parent 2a7adff commit c7a8209
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/ata/libata-sff.c
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ EXPORT_SYMBOL_GPL(ata_sff_dev_select);
* LOCKING:
* caller.
*/
void ata_dev_select(struct ata_port *ap, unsigned int device,
static void ata_dev_select(struct ata_port *ap, unsigned int device,
unsigned int wait, unsigned int can_sleep)
{
if (ata_msg_probe(ap))
Expand Down
3 changes: 0 additions & 3 deletions drivers/ata/libata.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,6 @@ static inline int sata_pmp_attach(struct ata_device *dev)

/* libata-sff.c */
#ifdef CONFIG_ATA_SFF
extern void ata_dev_select(struct ata_port *ap, unsigned int device,
unsigned int wait, unsigned int can_sleep);
extern u8 ata_irq_on(struct ata_port *ap);
extern void ata_pio_task(struct work_struct *work);
#endif /* CONFIG_ATA_SFF */

Expand Down

0 comments on commit c7a8209

Please sign in to comment.