Skip to content

Commit

Permalink
net: cacheline adjust struct netns_frags for better frag performance
Browse files Browse the repository at this point in the history
This small cacheline adjustment of struct netns_frags improves
performance significantly for the fragmentation code.

Struct members 'lru_list' and 'mem' are both hot elements, and it
hurts performance, due to cacheline bouncing at every call point,
when they share a cacheline.  Also notice, how mem is placed
together with 'high_thresh' and 'low_thresh', as they are used in
the compare operations together.

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jesper Dangaard Brouer authored and David S. Miller committed Jan 29, 2013
1 parent 656a05c commit cd39a78
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion include/net/inet_frag.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@

struct netns_frags {
int nqueues;
atomic_t mem;
struct list_head lru_list;

/* Its important for performance to keep lru_list and mem on
* separate cachelines
*/
atomic_t mem ____cacheline_aligned_in_smp;
/* sysctls */
int timeout;
int high_thresh;
Expand Down

0 comments on commit cd39a78

Please sign in to comment.