Skip to content

Commit

Permalink
drm/exec, drm/gpuvm: Prefer u32 over uint32_t
Browse files Browse the repository at this point in the history
The relatively recently introduced drm/exec utility was using uint32_t
in its interface, which was then also carried over to drm/gpuvm.

Prefer u32 in new code and update drm/exec and drm/gpuvm accordingly.

Cc: Christian König <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@redhat.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240119090557.6360-1-thomas.hellstrom@linux.intel.com
  • Loading branch information
Thomas Hellström committed Jan 22, 2024
1 parent 87399f1 commit cf41ceb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/drm_exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ static void drm_exec_unlock_all(struct drm_exec *exec)
*
* Initialize the object and make sure that we can track locked objects.
*/
void drm_exec_init(struct drm_exec *exec, uint32_t flags)
void drm_exec_init(struct drm_exec *exec, u32 flags)
{
exec->flags = flags;
exec->objects = kmalloc(PAGE_SIZE, GFP_KERNEL);
Expand Down
4 changes: 2 additions & 2 deletions include/drm/drm_exec.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ struct drm_exec {
/**
* @flags: Flags to control locking behavior
*/
uint32_t flags;
u32 flags;

/**
* @ticket: WW ticket used for acquiring locks
Expand Down Expand Up @@ -135,7 +135,7 @@ static inline bool drm_exec_is_contended(struct drm_exec *exec)
return !!exec->contended;
}

void drm_exec_init(struct drm_exec *exec, uint32_t flags);
void drm_exec_init(struct drm_exec *exec, u32 flags);
void drm_exec_fini(struct drm_exec *exec);
bool drm_exec_cleanup(struct drm_exec *exec);
int drm_exec_lock_obj(struct drm_exec *exec, struct drm_gem_object *obj);
Expand Down
2 changes: 1 addition & 1 deletion include/drm/drm_gpuvm.h
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ struct drm_gpuvm_exec {
/**
* @flags: the flags for the struct drm_exec
*/
uint32_t flags;
u32 flags;

/**
* @vm: the &drm_gpuvm to lock its DMA reservations
Expand Down

0 comments on commit cf41ceb

Please sign in to comment.