From bd53ce4da252ddb1ae4257c164f80aea3d8ab90c Mon Sep 17 00:00:00 2001 From: Miaohe Lin Date: Thu, 17 Feb 2022 16:58:42 +0800 Subject: [PATCH 1/2] mm/slob: make kmem_cache_boot static kmem_cache_boot is never accessed outside slob.c. Make it static. Signed-off-by: Miaohe Lin Acked-by: David Rientjes Signed-off-by: Vlastimil Babka Link: https://lore.kernel.org/r/20220217085842.29032-1-linmiaohe@huawei.com --- mm/slob.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slob.c b/mm/slob.c index 60c5842215f1b..1179bcad2df85 100644 --- a/mm/slob.c +++ b/mm/slob.c @@ -708,7 +708,7 @@ int __kmem_cache_shrink(struct kmem_cache *d) return 0; } -struct kmem_cache kmem_cache_boot = { +static struct kmem_cache kmem_cache_boot = { .name = "kmem_cache", .size = sizeof(struct kmem_cache), .flags = SLAB_PANIC, From 7d6b6cc355378a66044cbd25ccee4153bf60dea9 Mon Sep 17 00:00:00 2001 From: Miaohe Lin Date: Thu, 17 Feb 2022 17:16:09 +0800 Subject: [PATCH 2/2] mm/slab_common: use helper function is_power_of_2() Use helper function is_power_of_2() to check if KMALLOC_MIN_SIZE is power of two. Minor readability improvement. Signed-off-by: Miaohe Lin Signed-off-by: Vlastimil Babka Link: https://lore.kernel.org/r/20220217091609.8214-1-linmiaohe@huawei.com --- mm/slab_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 23f2ab0713b77..6ee64d6208b39 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -807,7 +807,7 @@ void __init setup_kmalloc_cache_index_table(void) unsigned int i; BUILD_BUG_ON(KMALLOC_MIN_SIZE > 256 || - (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1))); + !is_power_of_2(KMALLOC_MIN_SIZE)); for (i = 8; i < KMALLOC_MIN_SIZE; i += 8) { unsigned int elem = size_index_elem(i);