Skip to content

Commit

Permalink
vfio-ccw: Add a trace for asynchronous requests
Browse files Browse the repository at this point in the history
Since the asynchronous requests are typically associated with
error recovery, let's add a simple trace when one of those is
issued to a device.

Signed-off-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20191016142040.14132-4-farman@linux.ibm.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
  • Loading branch information
Eric Farman authored and Cornelia Huck committed Oct 17, 2019
1 parent 970ebeb commit d5950b0
Showing 3 changed files with 35 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/s390/cio/vfio_ccw_fsm.c
Original file line number Diff line number Diff line change
@@ -341,6 +341,10 @@ static void fsm_async_request(struct vfio_ccw_private *private,
/* should not happen? */
cmd_region->ret_code = -EINVAL;
}

trace_vfio_ccw_fsm_async_request(get_schid(private),
cmd_region->command,
cmd_region->ret_code);
}

/*
1 change: 1 addition & 0 deletions drivers/s390/cio/vfio_ccw_trace.c
Original file line number Diff line number Diff line change
@@ -9,5 +9,6 @@
#define CREATE_TRACE_POINTS
#include "vfio_ccw_trace.h"

EXPORT_TRACEPOINT_SYMBOL(vfio_ccw_fsm_async_request);
EXPORT_TRACEPOINT_SYMBOL(vfio_ccw_fsm_event);
EXPORT_TRACEPOINT_SYMBOL(vfio_ccw_io_fctl);
30 changes: 30 additions & 0 deletions drivers/s390/cio/vfio_ccw_trace.h
Original file line number Diff line number Diff line change
@@ -17,6 +17,36 @@

#include <linux/tracepoint.h>

TRACE_EVENT(vfio_ccw_fsm_async_request,
TP_PROTO(struct subchannel_id schid,
int command,
int errno),
TP_ARGS(schid, command, errno),

TP_STRUCT__entry(
__field(u8, cssid)
__field(u8, ssid)
__field(u16, sch_no)
__field(int, command)
__field(int, errno)
),

TP_fast_assign(
__entry->cssid = schid.cssid;
__entry->ssid = schid.ssid;
__entry->sch_no = schid.sch_no;
__entry->command = command;
__entry->errno = errno;
),

TP_printk("schid=%x.%x.%04x command=0x%x errno=%d",
__entry->cssid,
__entry->ssid,
__entry->sch_no,
__entry->command,
__entry->errno)
);

TRACE_EVENT(vfio_ccw_fsm_event,
TP_PROTO(struct subchannel_id schid, int state, int event),
TP_ARGS(schid, state, event),

0 comments on commit d5950b0

Please sign in to comment.