Skip to content

Commit

Permalink
hrtimer: remove hrtimer_clock_base::get_softirq_time()
Browse files Browse the repository at this point in the history
Peter Zijlstra noticed this 8 months ago and I just noticed
it again.

hrtimer_clock_base::get_softirq_time() is currently unused
in the entire tree. In fact, looking at the logs, it appears
as if it was never used. Remove it.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Mark McLoughlin authored and Ingo Molnar committed Sep 22, 2008
1 parent d82f0b0 commit d7cfb60
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions include/linux/hrtimer.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ struct hrtimer_sleeper {
* @first: pointer to the timer node which expires first
* @resolution: the resolution of the clock, in nanoseconds
* @get_time: function to retrieve the current time of the clock
* @get_softirq_time: function to retrieve the current time from the softirq
* @softirq_time: the time when running the hrtimer queue in the softirq
* @offset: offset of this clock to the monotonic base
* @reprogram: function to reprogram the timer event
Expand All @@ -157,7 +156,6 @@ struct hrtimer_clock_base {
struct rb_node *first;
ktime_t resolution;
ktime_t (*get_time)(void);
ktime_t (*get_softirq_time)(void);
ktime_t softirq_time;
#ifdef CONFIG_HIGH_RES_TIMERS
ktime_t offset;
Expand Down
4 changes: 1 addition & 3 deletions kernel/hrtimer.c
Original file line number Diff line number Diff line change
Expand Up @@ -1401,9 +1401,7 @@ void hrtimer_run_queues(void)
if (!base->first)
continue;

if (base->get_softirq_time)
base->softirq_time = base->get_softirq_time();
else if (gettime) {
if (gettime) {
hrtimer_get_softirq_time(cpu_base);
gettime = 0;
}
Expand Down

0 comments on commit d7cfb60

Please sign in to comment.