Skip to content

Commit

Permalink
irqchip: brcmstb-l2: Fix error handling of irq_of_parse_and_map
Browse files Browse the repository at this point in the history
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Kevin Cernekee <cernekee@gmail.com> 
Link: https://lkml.kernel.org/r/20141114221642.GA37468@dtor-ws
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
  • Loading branch information
Dmitry Torokhov authored and Jason Cooper committed Nov 26, 2014
1 parent 714710e commit d99ba44
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/irqchip/irq-brcmstb-l2.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np,
__raw_writel(0xffffffff, data->base + CPU_CLEAR);

data->parent_irq = irq_of_parse_and_map(np, 0);
if (data->parent_irq < 0) {
if (!data->parent_irq) {
pr_err("failed to find parent interrupt\n");
ret = data->parent_irq;
ret = -EINVAL;
goto out_unmap;
}

Expand Down

0 comments on commit d99ba44

Please sign in to comment.