From da8269a3e9edb8c57cd5448e07a5157872ddd143 Mon Sep 17 00:00:00 2001 From: Anand Jain Date: Sat, 11 Feb 2023 00:15:54 +0800 Subject: [PATCH] btrfs: avoid reusing return variable in nested block in btrfs_lookup_bio_sums The function btrfs_lookup_bio_sums() and a nested if statement declare ret respectively as blk_status_t and int. There is no need to store the return value of search_file_offset_in_bio() to ret as this is a one-time call. Reviewed-by: Christoph Hellwig Signed-off-by: Anand Jain Reviewed-by: David Sterba Signed-off-by: David Sterba --- fs/btrfs/file-item.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/file-item.c b/fs/btrfs/file-item.c index 41c77a1008535..89e9415b8f06d 100644 --- a/fs/btrfs/file-item.c +++ b/fs/btrfs/file-item.c @@ -494,12 +494,11 @@ blk_status_t btrfs_lookup_bio_sums(struct btrfs_bio *bbio) if (inode->root->root_key.objectid == BTRFS_DATA_RELOC_TREE_OBJECTID) { u64 file_offset; - int ret; - ret = search_file_offset_in_bio(bio, - &inode->vfs_inode, - cur_disk_bytenr, &file_offset); - if (ret) + if (search_file_offset_in_bio(bio, + &inode->vfs_inode, + cur_disk_bytenr, + &file_offset)) set_extent_bits(io_tree, file_offset, file_offset + sectorsize - 1, EXTENT_NODATASUM);