Skip to content

Commit

Permalink
Revert "swiotlb-xen: pass dev_addr to swiotlb_tbl_unmap_single"
Browse files Browse the repository at this point in the history
This reverts commit 2c3fc8d.

This commit broke on x86 PV because entries in the generic SWIOTLB are
indexed using (pseudo-)physical address not DMA address and these are
not the same in a x86 PV guest.

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
  • Loading branch information
David Vrabel committed Dec 11, 2014
1 parent 76f0a48 commit dbdd747
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/xen/swiotlb-xen.c
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ static void xen_unmap_single(struct device *hwdev, dma_addr_t dev_addr,

/* NOTE: We use dev_addr here, not paddr! */
if (is_xen_swiotlb_buffer(dev_addr)) {
swiotlb_tbl_unmap_single(hwdev, dev_addr, size, dir);
swiotlb_tbl_unmap_single(hwdev, paddr, size, dir);
return;
}

Expand Down

0 comments on commit dbdd747

Please sign in to comment.